[Whonix-devel] #25140 [Core Tor/Tor]: Parse only .torrc files in torrc.d directory

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Feb 21 00:31:12 CET 2019

#25140: Parse only .torrc files in torrc.d directory
 Reporter:  iry                                  |          Owner:
                                                 |  Jigsaw52
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
 Severity:  Major                                |     Resolution:
 Keywords:  034-triage-20180328,                 |  Actual Points:
  035-removed-20180711                           |
Parent ID:                                       |         Points:
 Reviewer:  ahf                                  |        Sponsor:
Changes (by Jigsaw52):

 * status:  needs_revision => needs_review


 I agree but the tor_glob function was changed by a later commit.

 After developing get_glob_opened_files in commit
 the Windows version of tor_glob ended up sharing much of the code with
 get_glob_opened_files (due to both needing to expand path components with
 globs manually). Because of that, all the common code has been split into
 smaller functions in commit c5883f356f92aca478450f0e09d6caac53ce2085

 I think it might be easier to review this pull request code by looking at
 the diff for the whole pull request (the files changed tab in github).
 I've avoided squashing the first 4 commits because they were already
 reviewed in
 https://trac.torproject.org/projects/tor/ticket/25140#comment:19 but I now
 wish I hadn't as the pull request would be easier to read if they had been

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25140#comment:37>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the Whonix-devel mailing list